git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] range-diff: allow to diff files regardless submodule

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 24, 2018, 02:12 UTC
Message-ID
<xmqqh8hcqeho.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181023140710.GA7073@ldmartin-desk.jf.intel.com>
Lucas De Marchi <lucas.demarchi@intel.com> writes:
Show 6 quoted lines
>> Yes, I agree on both counts (i.e. it was totally unclear what
>> problem is being solved and what the root cause of the problem is,
>> and we would want a new test to protect this "fix" from getting
>> broken in the future.
>
> have you seen I sent a v2 with proper test?

No, otherwise I wouln't have said it needs tests, and no, because I haven't seen the v2, I do not know if it came with proper test or other issues pointed out and fixes suggested in the review round were addressed in v2. Sorry.

When you ask such a question, please accompany it with "this is the message-id" to avoid the receiver of the question locating a wrong version of your patch from the archive.

Thanks.
Previous: Lucas De MarchiNext: Lucas De Marchi
Message 12 of 17 in “range-diff: allow to diff files regardless submodule”
  1. range-diff: allow to diff files regardless submoduleLucas De Marchi, Oct 10, 2018
  2. brian m. carlsonOct 11, 2018
  3. Lucas De MarchiOct 11, 2018
  4. Johannes SchindelinOct 12, 2018
  5. brian m. carlsonOct 12, 2018
  6. Ævar Arnfjörð BjarmasonOct 11, 2018
  7. Lucas De MarchiOct 11, 2018
  8. range-diff: allow to diff files regardless submoduleLucas De Marchi, Oct 11, 2018
  9. Johannes SchindelinOct 12, 2018
  10. Junio C HamanoOct 11, 2018
  11. Lucas De MarchiOct 23, 2018
  12. Junio C HamanoOct 24, 2018
  13. Lucas De MarchiOct 24, 2018
  14. Junio C HamanoOct 24, 2018
  15. Junio C HamanoOct 24, 2018
  16. Lucas De MarchiOct 24, 2018
  17. range-diff: allow to diff files regardless of submodule configLucas De Marchi, Oct 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.