Re: [PATCH] range-diff: allow to diff files regardless submodule
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 11, 2018, 00:02 UTC
- Message-ID
- <20181011000233.GX432229@genre.crustytoothpaste.net>
- In-Reply-To
- <20181010150916.4295-1-lucas.demarchi@intel.com>
On Wed, Oct 10, 2018 at 08:09:16AM -0700, Lucas De Marchi wrote:
Show 24 quoted lines
> Do like it's done in grep so mode doesn't end up as
> 0160000, which means range-diff doesn't work if one has
> "submodule.diff = log" in the configuration. Without this
> while using range-diff I only get a
>
> Submodule a 0000000...0000000 (new submodule)
>
> instead of the diff between the revisions.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> range-diff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/range-diff.c b/range-diff.c
> index 60edb2f518..bd8083f2d1 100644
> --- a/range-diff.c
> +++ b/range-diff.c
> @@ -354,7 +354,7 @@ static struct diff_filespec *get_filespec(const char *name, const char *p)
> {
> struct diff_filespec *spec = alloc_filespec(name);
>
> - fill_filespec(spec, &null_oid, 0, 0644);
> + fill_filespec(spec, &null_oid, 0, 0100644);If we have a system that has different mode values from the common Unix ones, is this still correct or does it need to change?
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204