git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/notes: remove unnecessary free

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 13, 2018, 01:29 UTC
Message-ID
<xmqqh8glzrx8.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CALKQrgdCNxXSOG-KRUeNaw2q=hOGh9+-zM5ATHwmDEmOC7UAcw@mail.gmail.com>
Johan Herland <johan@herland.net> writes:
Show 6 quoted lines
> On Sun, Nov 11, 2018 at 10:49 AM Carlo Marcelo Arenas Belón
> <carenas@gmail.com> wrote:
>>
>> 511726e4b1 ("builtin/notes: fix premature failure when trying to add
>> the empty blob", 2014-11-09) removed the check for !len but left a
>> call to free the buffer that will be otherwise NULL
Wow, that's a old one.
>>
>> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>
> Signed-off-by: Johan Herland <johan@herland.net>
Thanks, both.  Will apply.
Previous: Johan Herland
Message 3 of 3 in “builtin/notes: remove unnecessary free”
  1. builtin/notes: remove unnecessary freeCarlo Marcelo Arenas Belón, Nov 11, 2018
  2. Johan HerlandNov 11, 2018
  3. Junio C HamanoNov 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.