From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Nov 2018 01:29:07 GMT
Subject: Re: [PATCH] builtin/notes: remove unnecessary free
Message-ID: <xmqqh8glzrx8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CALKQrgdCNxXSOG-KRUeNaw2q=hOGh9+-zM5ATHwmDEmOC7UAcw@mail.gmail.com>

Johan Herland <johan@herland.net> writes:

> On Sun, Nov 11, 2018 at 10:49 AM Carlo Marcelo Arenas Belón
> <carenas@gmail.com> wrote:
>>
>> 511726e4b1 ("builtin/notes: fix premature failure when trying to add
>> the empty blob", 2014-11-09) removed the check for !len but left a
>> call to free the buffer that will be otherwise NULL

Wow, that's a old one.

>>
>> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>
> Signed-off-by: Johan Herland <johan@herland.net>

Thanks, both.  Will apply.