Re: Fwd: [PATCH] optimize PNGs with FileOptimizer 13.50.2431 (x86) and ZopfliPNG 1.0.2

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 24, 2019, 21:15 UTC
Message-ID: <xmqqh8dxhi4o.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190124190458.GA29828@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Thu, Jan 24, 2019 at 06:34:29PM +0000, Lucy Phipps wrote:
>
>> honestly i just like optimizing files. the test images still work but
>> one of them is half the size as before. i don't know if it needs to be
>> bigger. it doesn't make any actual difference
>
> I'm not sure if we actually see any benefit to optimizing them, though.
>
> Optimizing a file which is served to many clients makes sense. So these:
>
>> > >  gitweb/static/git-favicon.png | Bin 115 -> 106 bytes
>> > >  gitweb/static/git-logo.png    | Bin 207 -> 204 bytes
>
> should be optimized (and largely already are, from the byte counts).

67e56eca ("gitweb: Optimize git-favicon.png", 2009-08-10)