Re: Fwd: [PATCH] optimize PNGs with FileOptimizer 13.50.2431 (x86) and ZopfliPNG 1.0.2

From: Jeff King <peff@peff.net>
Date: Jan 24, 2019, 19:04 UTC
Message-ID: <20190124190458.GA29828@sigill.intra.peff.net>
In-Reply-To: <CAGOd_F8A7Tfgb8cD1qvi2WDKYXLp=Zf_Yopb38gFpRQoj0tcdg@mail.gmail.com>

On Thu, Jan 24, 2019 at 06:34:29PM +0000, Lucy Phipps wrote:

> honestly i just like optimizing files. the test images still work but
> one of them is half the size as before. i don't know if it needs to be
> bigger. it doesn't make any actual difference

I'm not sure if we actually see any benefit to optimizing them, though.

Optimizing a file which is served to many clients makes sense. So these:

> > >  gitweb/static/git-favicon.png | Bin 115 -> 106 bytes
> > >  gitweb/static/git-logo.png    | Bin 207 -> 204 bytes

should be optimized (and largely already are, from the byte counts).

But these:

> > >  t/test-binary-1.png           | Bin 5660 -> 2603 bytes
> > >  t/test-binary-2.png           | Bin 275 -> 217 bytes

never go anywhere except developer's working trees. And since the history is kept in Git, we keep the original version of the file, too. So this is actually making git.git slightly _larger_, even though checked-out file in the working tree is smaller.

I'm not sure that's worth the tradeoff.

-Peff