Re: What's cooking in git.git (Apr 2020, #01; Wed, 15)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2020, 22:18 UTC
Message-ID: <xmqqh7xjxeew.fsf@gitster.c.googlers.com>
In-Reply-To: <20200416213009.GA1721147@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 24 quoted lines

> On Thu, Apr 16, 2020 at 11:12:08PM +0200, Damien Robert wrote:
>
>> From Junio C Hamano, Wed 15 Apr 2020 at 16:01:52 (-0700):
>> > * dr/push-remoteref-fix (2020-04-06) 2 commits
>> >   (merged to 'next' on 2020-04-15 at ecf60dc488)
>> >  + remote.c: fix handling of %(push:remoteref)
>> >  + remote.c: fix %(push) for triangular workflows
>> 
>> Hi Junio,
>> 
>> I just sent a new version of this series, which drop the second patch for
>> now. As outlined in my cover letter in
>> https://public-inbox.org/git/20200406175648.25737-1-damien.olivier.robert+git@gmail.com/
>> the triangular workflow patch still leaves some corner cases (and for now
>> is missing reviews).
>> 
>> I'd prefer to fix all of them at once, rather than have an almost working
>> patch. Jeff seems to be of the same opinion in
>> https://public-inbox.org/git/20200406214607.GA1251506@coredump.intra.peff.net/
>
> Yeah, I'm sorry I haven't looked at the latest revision of the series.
> The security fix and some other stuff has been keeping me busy. If
> somebody else has time to review, please don't wait one me. But
> otherwise, it is on my list and I'll get to it eventually.

Thanks. In any case, they already are in 'next', so please update incrementally. In an early part of the development cycle of a topic, we tend to avoid building a topic from a horribly broken state and fix things up with pile of "oops, that was wrong, and here is a band-aid" patches, but once the patches become reviewable shape, the remaining "issues" tend to be the ones that are not found without careful reviewing and thinking things through, and it often is easier for later history inspection if the fixes are separate.

Thanks.