git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Apr 2020, #01; Wed, 15)

From
DRDamien Robert <damien.olivier.robert@gmail.com>
Date
Apr 16, 2020, 22:47 UTC
Message-ID
<20200416224708.zr4dlrz4hpaqsz2s@doriath>
In-Reply-To
<xmqqh7xjxeew.fsf@gitster.c.googlers.com>
From Junio C Hamano, Thu 16 Apr 2020 at 15:18:47 (-0700) :
Show 8 quoted lines
> Thanks.  In any case, they already are in 'next', so please update
> incrementally.  In an early part of the development cycle of a topic, we
> tend to avoid building a topic from a horribly broken state and fix
> things up with pile of "oops, that was wrong, and here is a band-aid"
> patches, but once the patches become reviewable shape, the remaining
> "issues" tend to be the ones that are not found without careful reviewing
> and thinking things through, and it often is easier for later history
> inspection if the fixes are separate.

I am a bit confused because in next you picked both the original patch fixing the fallback to default %(push:remoteref) behavior, and the new RFC patch fixing triangular workflow (which has not yet been reviewed). But your argument seems to indicate you would have preferred two separate topics.

That's indeed why the patch I sent today drops the triangular workflow patch for now.

I think this is my fault, I should have sent the RFC patches fixing the triangular workflow which you picked (along with the original patch reviewed by Jeff) in a separate thread, so there were no risk of confusion (which was increased by the fact that my cover letter for this indicated version 4 while the patches were actually version 6).

The triangular workflow patch is not quite correct in the sense that it does not handle (yet) all cases, but on the other hand you could argue that this is indeed better than the current code which is always wrong in the triangular case.

Sorry I did not catch this sooner :-(
-- 
Damien
Previous: Junio C HamanoNext: Damien Robert
Message 7 of 18 in “What's cooking in git.git (Apr 2020, #01; Wed, 15)”
  1. Junio C HamanoApr 15, 2020
  2. Elijah NewrenApr 16, 2020
  3. Junio C HamanoApr 16, 2020
  4. Damien RobertApr 16, 2020
  5. Jeff KingApr 16, 2020
  6. Junio C HamanoApr 16, 2020
  7. Damien RobertApr 16, 2020
  8. Damien RobertApr 16, 2020
  9. Junio C HamanoApr 16, 2020
  10. Damien RobertApr 17, 2020
  11. Junio C HamanoApr 17, 2020
  12. Damien RobertApr 17, 2020
  13. Junio C HamanoApr 17, 2020
  14. Damien RobertApr 18, 2020
  15. Danh DoanApr 17, 2020
  16. Junio C HamanoApr 17, 2020
  17. Danh DoanApr 17, 2020
  18. Junio C HamanoApr 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.