Re: [PATCH v3 2/3] ref-filter: handle CRLF at end-of-line more gracefully
"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> - for (i = 0; i < len; i++)
> - if (r[i] == '\n')
> - r[i] = ' ';
> + for (int i = 0; i < len; i++) {We do not allow this in our codebase (yet).
cf. Documentation/CodingGuidelines
- Declaring a variable in the for loop "for (int i = 0; i < 10; i++)"
is still not allowed in this codebase.
Show 19 quoted lines
> diff --git a/t/t3203-branch-output.sh b/t/t3203-branch-output.sh
> index 71818b90f0..c06eca774f 100755
> --- a/t/t3203-branch-output.sh
> +++ b/t/t3203-branch-output.sh
> @@ -3,13 +3,11 @@
> test_description='git branch display tests'
> . ./test-lib.sh
> . "$TEST_DIRECTORY"/lib-terminal.sh
> +. "$TEST_DIRECTORY"/lib-crlf-messages.sh
>
> test_expect_success 'make commits' '
> - echo content >file &&
> - git add file &&
> - git commit -m one &&
> - echo content >>file &&
> - git commit -a -m two
> + test_commit one &&
> + test_commit two
> '
What does this change have to do with the topic at hand?
Junio C Hamano <gitster@pobox.com>