Re: [PATCH v4 1/2] ref-filter: handle CRLF at end-of-line more gracefully
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 28, 2020, 20:24 UTC
- Message-ID
- <xmqq1rhi9jzl.fsf@gitster.c.googlers.com>
- In-Reply-To
- <FFAF7079-C759-43F3-96AA-CAF3B73B55B4@gmail.com>
Philippe Blain <levraiphilippeblain@gmail.com> writes:
Show 25 quoted lines
>> Having said all that. >> >> Here is how I explained the topic in the "What's cooking" report. >> >> A commit and tag object may have CR at the end of each and >> every line (you can create such an object with hash-object or >> using --cleanup=verbatim to decline the default clean-up >> action), but it would make it impossible to have a blank line >> to separate the title from the body of the message. Be lenient >> and accept a line with lone CR on it as a blank line, too. > > Just for the sake of searchability, I think it would be good to have > CRLF spelled out in this topic description (since I gather this is what > ends up in the release notes). But I don't feel that strongly > about that. > >> Let's not call this change a "bug fix". The phrase you used in your >> title, "more gracefully", is a very good one. > > It was your suggestion ;) > >> In the meantime, I've squashed your "oops forgot ||return 1" change >> into [PATCH 2/2]. > > Thanks for squashing it in.
Squashing in the "oops forgot || return 1" was the only thing I did. I did not rewrite (and will not do so myself) the proposed log message 1/2, which needs to happen before the topic can hit 'next'.
Thanks.