Re: [PATCH v2 3/3] bundle: remove "ref_list" in favor of string-list.c API

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 29, 2021, 01:02 UTC
Message-ID: <xmqqh7hh4h5e.fsf@gitster.g>
In-Reply-To: <YNS8vzPc1KyRaSR5@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> I think this is a good direction, and I didn't see any errors in the
> code. It's slightly sad that we end up with more lines than we started
> with, but I think that's mostly because you're actually freeing the
> memory now.
> ...
> I.e., I think:
>
>   if (is_prereq)
>           string_list_append(&header->prerequisites, "")->util = oid;
>   else
>           string_list_append(&header->references, p + 1)->util = oid;
>
> is much more obvious.

Nicely done and nicely reviewed and improved.

Together with the "no point in freeing just before dying" on the earlier step, polishing this topic to incorporate the suggested changes should be fairly an easy task. Let's not leave too many loose ends hanging around and close this one with the last final reroll (hopefully without "I did this too while at it" that meets "oh, well, that is a bit controversi8al" to drag it unnecessarily out).

Thanks.