Re: [PATCH v4 0/3] bundle.c: remove "ref_list" in favor of string-list.c API

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 3, 2021, 11:28 UTC
Message-ID: <87y2an8wlv.fsf@evledraar.gmail.com>
In-Reply-To: <YOBBgfiaz59KdsWS@coredump.intra.peff.net>

On Sat, Jul 03 2021, Jeff King wrote:

Show 14 quoted lines

> On Fri, Jul 02, 2021 at 11:57:29AM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> This re-roll of v3 changes the discussion in the 1/3 commit message,
>> it incorrectly referred to SANITIZE=leak when I meant valgrind.
>> 
>> I also changed the bundle_header_init() pattern to use the same
>> "memcpy() a blank" as in my parallel series to do that more generally.
>
> Thanks, this looks good to me.
>
> I'd probably word the discussion about die() a bit differently, but you've
> already seen my expositions on leak-checking, and it's all tangent here.
> So let's move forward with this, and we can let leak-checking
> philosophies iron themselves out as we fix more cases. :)

Thanks for the detailed review over multiple rounds.