Re: jc/stash-drop

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2022, 18:22 UTC
Message-ID: <xmqqh789sjuq.fsf@gitster.g>
In-Reply-To: <220305.86y21o327b.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 18 quoted lines

> On Thu, Mar 03 2022, Junio C Hamano wrote:
>
>> * jc/stash-drop (2022-03-02) 3 commits
>>  - stash: call reflog_delete() in reflog.c
>>  - reflog: libify delete reflog function and helpers
>>  - stash: add tests to ensure reflog --rewrite --updatref behavior
>>
>>  "git stash drop" is reimplemented as an internal call to
>>  reflog_delete() function, instead of invoking "git reflog delete"
>>  via run_command() API.
>>
>>  Will merge to 'next'?
>>  source: <pull.1218.v4.git.git.1646260044.gitgitgadget@gmail.com>
>
> I've been reviewing this closely & it looks good to me, all feedback has
> been addressed, and there's nothing outstanding (there's one sub-thread
> on v4 answering a question from Phillip Wood asking if the new test
> needs REFFILES, it does).

I think this one is good, and I agree that we should leave the "old side is not even visible to regular users and tests need to peek into the implementation detail of the log files---do we need the --rewrite option at all, instead of doing so always?" outside the topic.

Thanks.