jc/stash-drop (was: What's cooking in git.git (Mar 2022, #01; Thu, 3))

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 5, 2022, 14:25 UTC
Message-ID: <220305.86y21o327b.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqqv8wu2vag.fsf@gitster.g>

On Thu, Mar 03 2022, Junio C Hamano wrote:

Show 11 quoted lines

> * jc/stash-drop (2022-03-02) 3 commits
>  - stash: call reflog_delete() in reflog.c
>  - reflog: libify delete reflog function and helpers
>  - stash: add tests to ensure reflog --rewrite --updatref behavior
>
>  "git stash drop" is reimplemented as an internal call to
>  reflog_delete() function, instead of invoking "git reflog delete"
>  via run_command() API.
>
>  Will merge to 'next'?
>  source: <pull.1218.v4.git.git.1646260044.gitgitgadget@gmail.com>

I've been reviewing this closely & it looks good to me, all feedback has been addressed, and there's nothing outstanding (there's one sub-thread on v4 answering a question from Phillip Wood asking if the new test needs REFFILES, it does).