Re: [PATCH v7 4/4] vimdiff: add description to already existing diff/merge tools

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2022, 16:38 UTC
Message-ID: <xmqqh77gww6c.fsf@gitster.g>
In-Reply-To: <20220328223019.271270-5-greenfoo@u92.eu>

Fernando Ramos <greenfoo@u92.eu> writes:

> ---

Missing log message and sign off. "add description" tells us what it did, which is easily visible in the patch text already. The log message should say why we are adding them, and the rationale has to be better than "adding is better than not adding". E.g. "in output of X and Y, we only show the names without explanation on what they are, which is not helpful enough" would be a helpful log message.

Doesn't the change in [3/4] to include these strings in generated mergetools-*.txt file depend on this in place?

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.