Re: [PATCH v7 4/4] vimdiff: add description to already existing diff/merge tools

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Mar 29, 2022, 17:24 UTC
Message-ID: <f56a7a0b-8525-c4cc-7bc7-5ac4bba59206@gmail.com>
In-Reply-To: <xmqqh77gww6c.fsf@gitster.g>

Hi Junio, Fernando,

Le 2022-03-29 à 12:38, Junio C Hamano a écrit :

Show 10 quoted lines

> Fernando Ramos <greenfoo@u92.eu> writes:
> 
>> ---
> 
> Missing log message and sign off.  "add description" tells us what
> it did, which is easily visible in the patch text already.  The log
> message should say why we are adding them, and the rationale has to
> be better than "adding is better than not adding".  E.g. "in output
> of X and Y, we only show the names without explanation on what they
> are, which is not helpful enough" would be a helpful log message.

I might add that the prefix of the commit message title should be changed to 'mergetools: '

Show 6 quoted lines

> 
> Doesn't the change in [3/4] to include these strings in generated
> mergetools-*.txt file depend on this in place?
> 
> Thanks.
>

The list of available values are already generated in the mergetools-diff.txt and mergetools-merge.txt files before this series. After 3/4 we also include the description of the values. In 3/4 descriptions are only added for vimdiff and friends, so the rest of the tools would simply be listed without descriptions. After 4/4 all tools have a description.