Re: [PATCH v4 1/3] t: regression git needs safe.directory when using sudo

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2022, 01:11 UTC
Message-ID: <xmqqh75w50w3.fsf@gitster.g>
In-Reply-To: <CAPUEspjppJh3+obLoNpP8ckHz=-0G=MEUUBHnrab6=Znv+RiUg@mail.gmail.com>

Carlo Arenas <carenas@gmail.com> writes:

Show 5 quoted lines

> one option would be to consolidate its use with the root repository
> that gets created in patch 3, which I could have done originally
> instead of just using the ones you provided almost AS-IS, or as you
> pointed out we could remove the safety net since it is not needed and
> it is buggy anyway.

I agree that there is no point to chown the directory, especially if it does not offer any additional safety of any sort. And quite honstly, a test that is designed to be run ONLY in a very controlled CI environment, it does not need one that complicates the tests.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.