git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: fix crlf handling for utf16 files on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 20, 2022, 17:18 UTC
Message-ID
<xmqqh73b3doo.fsf@gitster.g>
In-Reply-To
<AS1PR02MB8185D1041A96B0384554EE32948E9@AS1PR02MB8185.eurprd02.prod.outlook.com>
"Baumann, Moritz" <moritz.baumann@sap.com> writes:
> Do you need me to resubmit the patch with an explanatory
> description? If so, I can try to summarize the above.
Yup.

Review comments are not a request to the authors to explain their patches to reviewers. Their primary purpose is to point out what potential issues readers of the commit that would result by the proposed patches may have. So answering in your response to see if your clarifications are understandable is very good, but please consider it a preparation to write a better version (i.e. [PATCH v2]).

Thanks for working on this fix.
Previous: Baumann, MoritzNext: Moritz Baumann via GitGitGadget
Message 4 of 6 in “git-p4: fix crlf handling for utf16 files on Windows”
  1. git-p4: fix crlf handling for utf16 files on WindowsMoritz Baumann via GitGitGadget, Jul 20, 2022
  2. Junio C HamanoJul 20, 2022
  3. Baumann, MoritzJul 20, 2022
  4. Junio C HamanoJul 20, 2022
  5. git-p4: fix CR LF handling for utf16 filesMoritz Baumann via GitGitGadget, Jul 20, 2022
  6. Junio C HamanoJul 20, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.