git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-p4: fix crlf handling for utf16 files on Windows

From
MGMoritz Baumann via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 20, 2022, 05:27 UTC
Message-ID
<pull.1294.git.git.1658294873702.gitgitgadget@gmail.com>
From: Moritz Baumann <moritz.baumann@sap.com>
Signed-off-by: Moritz Baumann <moritz.baumann@sap.com>
---
    git-p4: fix crlf handling for utf16 files on Windows
    
    Signed-off-by: Moritz Baumann moritz.baumann@sap.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1294%2Fmbs-c%2Ffix-crlf-conversion-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1294/mbs-c/fix-crlf-conversion-v1
Pull-Request: https://github.com/git/git/pull/1294
 git-p4.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py
index 8fbf6eb1fe3..0a9d7e2ed7c 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -3148,7 +3148,7 @@ class P4Sync(Command, P4UserMap):
                     raise e
             else:
                 if p4_version_string().find('/NT') >= 0:
-                    text = text.replace(b'\r\n', b'\n')
+                    text = text.replace(b'\x0d\x00\x0a\x00', b'\x0a\x00')
                 contents = [text]
 
         if type_base == "apple":

base-commit: bbea4dcf42b28eb7ce64a6306cdde875ae5d09ca
-- 
gitgitgadget
Next: Junio C Hamano
Message 1 of 6 in “git-p4: fix crlf handling for utf16 files on Windows”
  1. git-p4: fix crlf handling for utf16 files on WindowsMoritz Baumann via GitGitGadget, Jul 20, 2022
  2. Junio C HamanoJul 20, 2022
  3. Baumann, MoritzJul 20, 2022
  4. Junio C HamanoJul 20, 2022
  5. git-p4: fix CR LF handling for utf16 filesMoritz Baumann via GitGitGadget, Jul 20, 2022
  6. Junio C HamanoJul 20, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.