Re: [PATCH v2 1/2] rebase: remove completely useless -C option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 20, 2023, 16:15 UTC
- Message-ID
- <xmqqh6wlxjuo.fsf@gitster.g>
- In-Reply-To
- <CABPp-BFakaEqnpW4Xn1rzcOC6oVmcEz+OxBV4dKA_TJZ-xbTvg@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 8 quoted lines
> On Fri, Jan 20, 2023 at 4:05 AM Junio C Hamano <gitster@pobox.com> wrote: >> ... >> That is, even when a patch does not cleanly apply with full context >> in the incoming diff, by requiring *smaller* number of lines to >> match, the diff *could* be forced to apply with reduced precision? > > Oh! Reducing the number of lines of context to pay attention to never > even occurred to me for whatever reason. I'll drop the patch.
Yup. "completely useless" on the title is less than half correct, but still correct for a minor use case where -C is used to use *more* context lines than the default.
We could update "rebase --apply" codepath to increase the context lines generated by format-patch. That would make the "completely useless" totally incorrect ;-)