Re: [PATCH v2 1/2] rebase: remove completely useless -C option

From: Martin Ågren <martin.agren@gmail.com>
Date: Jan 20, 2023, 09:55 UTC
Message-ID: <CAN0heSo8cqNqhx9+AJZJS2rwJxBG_HZjhgxQZf8nw5t82NDXBg@mail.gmail.com>
In-Reply-To: <a0f8f5fac1c3f79cd46b943e95636728677dffef.1674190573.git.gitgitgadget@gmail.com>

On Fri, 20 Jan 2023 at 06:27, Elijah Newren via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 10 quoted lines

>
> As per the git-apply documentation for the `-C` option:
>     Ensure at least <n> lines of surrounding context match...When fewer
>     lines of surrounding context exist they all must match.
>
> The fact that format-patch was not passed a -U option to increase the
> number of context lines meant that there would still only be 3 lines of
> context to match on.  So, anyone attempting to use this option in
> git-rebase would just be spinning their wheels and wasting time.  I was
> one such user a number of years ago.

I suppose someone might have something like GIT_DIFF_OPTS="--unified=20" meaning they would actually have more context for their `-C` to act on. So I guess there is a chance that someone somewhere has actually been able to make use of `git rebase -C` after all? I'm not really arguing either way -- just noting the possibility, as remote as it may be.

Martin