Re: [PATCH v9 4/6] notes.c: introduce '--separator=<paragraph-break>' option
This step seems to break CI asan/ubsan job
https://github.com/git/git/actions/runs/5260417146/jobs/9507299904#step:4:1826
Perhaps something like this is in order?
builtin/notes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git c/builtin/notes.c w/builtin/notes.c
index 6eede30597..785b1922ad 100644
--- c/builtin/notes.c
+++ w/builtin/notes.c
@@ -239,7 +239,7 @@ static void write_note_data(struct note_data *d, struct object_id *oid)
static void append_separator(struct strbuf *message)
{
- if (separator[strlen(separator) - 1] == '\n')
+ if (*separator && separator[strlen(separator) - 1] == '\n')
strbuf_addstr(message, separator);
else
strbuf_addf(message, "%s%s", separator, "\n");
Junio C Hamano <gitster@pobox.com>