Re: [PATCH v10 4/6] notes.c: introduce '[--[no-]separator|--separator=<paragraph-break>]' option

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: May 18, 2023, 14:34 UTC
Message-ID: <51690df7-1788-469f-aabe-84fc7a576951@app.fastmail.com>
In-Reply-To: <820dda0458994fdf7ff37870736ce6ed7871720c.1684411136.git.dyroneteng@gmail.com>

Hi

On Thu, May 18, 2023, at 14:02, Teng Long wrote:

> From: Teng Long <dyroneteng@gmail.com>
>
> When adding new notes or appending to an existing notes, we will
> insert a blank line between the paragraphs, like:

I was wondering why it acts this way. So of minor historical note (may be obvious to everyone else): it was in order to mirror how `git commit -m` works. From commit d9246d4303f (Teach "-m <msg>" and "-F <file>" to "git notes edit", 2009-10-09):

Show 10 quoted lines

> Teach "-m <msg>" and "-F <file>" to "git notes edit"
>
> The "-m" and "-F" options are already the established method
> (in both git-commit and git-tag) to specify a commit/tag message
> without invoking the editor. This patch teaches "git notes edit"
> to respect the same options for specifying a notes message without
> invoking the editor.
>
> Multiple "-m" and/or "-F" options are concatenated as separate
> paragraphs.

-- 
Kristoffer Haugsbakk