Re: [PATCH v2 2/4] config: report config parse errors using cb

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2023, 23:36 UTC
Message-ID: <xmqqh6nn3xq3.fsf@gitster.g>
In-Reply-To: <ZQyxmq7HB12/+YYv@google.com>

Josh Steadmon <steadmon@google.com> writes:

Show 7 quoted lines

> As Jonathan Tan mentioned in [1], on calling do_event() we set the start
> offset of the new event, and execute the callback for the previous event
> whose end offset we now know.
>
> I refactored this into "start_event()" and "flush_event()" functions as
> suggested, and added a new "do_event_and_flush()" function for the case
> where we want to immediately execute a callback for an event.

Very nicely done.  Thanks, both.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.