From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 21 Sep 2023 23:36:36 GMT
Subject: Re: [PATCH v2 2/4] config: report config parse errors using cb
Message-ID: <xmqqh6nn3xq3.fsf@gitster.g>
In-Reply-To: <ZQyxmq7HB12/+YYv@google.com>

Josh Steadmon <steadmon@google.com> writes:

> As Jonathan Tan mentioned in [1], on calling do_event() we set the start
> offset of the new event, and execute the callback for the previous event
> whose end offset we now know.
>
> I refactored this into "start_event()" and "flush_event()" functions as
> suggested, and added a new "do_event_and_flush()" function for the case
> where we want to immediately execute a callback for an event.

Very nicely done.  Thanks, both.