Re: [PATCH 1/4] global: convert trivial usages of `test <expr> -a/-o <expr>`

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2023, 22:56 UTC
Message-ID: <xmqqh6luzgc1.fsf@gitster.g>
In-Reply-To: <20231109184843.GC2711684@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> But IMHO it is worth getting rid of all -o/-a regardless. Even
> non-ambiguous cases make reasoning about the code harder, and we don't
> want to encourage people to think they're OK to use.

You're 100% correct. "We do not have to worry about it" is a very strong incentive to go after.

Show 5 quoted lines

>
>> I do not need a subshell for grouping, either.  Plain {} should do
>> (but you may need a LF or semicolon after the statement)..
>
> This I definitely agree with. :)

;-).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.