Re: [PATCH v2 1/4] global: convert trivial usages of `test <expr> -a/-o <expr>`
Patrick Steinhardt <ps@pks.im> writes:
Show 12 quoted lines
> Our coding guidelines say to not use `test` with `-a` and `-o` because
> it can easily lead to bugs. Convert trivial cases where we still use
> these to instead instead concatenate multiple invocations of `test` via
> `&&` and `||`, respectively.
>
> While not all of the converted instances can cause ambiguity, it is
> worth getting rid of all of them regardless:
>
> - It becomes easier to reason about the code as we do not have to
> argue why one use of `-a`/`-o` is okay while another one isn't.
>
> - We don't encourage people to use these expressions.
Thanks for these additional notes. Nicely done.