Re: [PATCH v2] ReviewingGuidelines: encourage positive reviews more

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 26, 2024, 20:20 UTC
Message-ID: <xmqqh6cbucpw.fsf@gitster.g>
In-Reply-To: <ZqOVC_F4fdQUognX@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

Show 13 quoted lines

> On Thu, Jul 25, 2024 at 08:49:34AM -0700, Junio C Hamano wrote:
>> I saw some contributors hesitate to give a positive review on
>> patches by their coworkers.  When written well, a positive review
>> does not have to be a hollow "looks good" that rubber stamps an
>> useless approval on a topic that is not interesting to others.
>> 
>> Let's add a few paragraphs to encourage positive reviews, which is a
>> bit harder to give than a review to point out things to improve.
>> 
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> This version looks good to me (well, the first version already did).
> Thanks!

Thanks; will mark for 'next'.