Re: [PATCH] ReviewingGuidelines: encourage positive reviews more
On Wed, Jul 24, 2024 at 5:14 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Let's add a few paragraphs to encourage positive reviews, which is a
> bit harder to give than a review to point out things to improve.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> diff --git c/Documentation/ReviewingGuidelines.txt w/Documentation/ReviewingGuidelines.txt
> @@ -72,12 +72,29 @@ guidance, and concrete tips for interacting with patches on the mailing list.
> +- Do not hesitate to give positive reviews on a series from your
> + work coleague. If your positive review is written well, it will
> + not make you look as if you two are representing corporate
> + interest on a series that is otherwise uninteresting to other
> + community members.
Eric Sunshine <sunshine@sunshineco.com>