Re: [PATCH v2 0/2] gpg-interface: expand gpg.program as a path

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 22, 2025, 20:28 UTC
Message-ID: <xmqqh5z4rmvd.fsf@gitster.g>
In-Reply-To: <20250722190922.51183-1-jonas.brandstoetter@gmx.at>

Jonas Brandstötter <jonas.brandstoetter@gmx.at> writes:

Show 22 quoted lines

> Allows users to specify a custom gpg program in their home directory.
>
> V2 adds test cases for when the gpg program is not set as an absolute path.
> The test for gpg in a home directory feels a bit wonky to me, because it
> assumes that `~` is an alias for `$HOME` and just overriding that variable
> with the test directory. But short of creating a user while running the
> tests, this is the best solution I could come up with.
>
> Jonas Brandstötter (2):
>   gpg-interface: expand gpg.program as a path
>   t7510: add test cases for non-absolute gpg program
>
>  Documentation/config/gpg.adoc |  2 +-
>  gpg-interface.c               |  2 +-
>  t/t7510-signed-commit.sh      | 12 +++++++++++-
>  3 files changed, 13 insertions(+), 3 deletions(-)
>
> Range-diff against v1:
> 1:  b551903c16 = 1:  b551903c16 gpg-interface: expand gpg.program as a path
> -:  ---------- > 2:  ca22bf2ee6 t7510: add test cases for non-absolute gpg program
> --
> 2.50.1

The first iteration of the patch was merged in the 'next' branch long time ago, and then to the 'master' branch already. It is way too late to wholesale replace the patch from the previous iteration.

It appears the first patch hasn't changed at all, so I'll just take the second patch as a separate, follow-up topic to add a missing test for already-graduated topic.

Thanks!