Re: [PATCH v2 2/2] t7510: add test cases for non-absolute gpg program

From: Jeff King <peff@peff.net>
Date: Jul 29, 2025, 07:12 UTC
Message-ID: <20250729071247.GA1426859@coredump.intra.peff.net>
In-Reply-To: <xmqq5xfbuahx.fsf@gitster.g>

On Mon, Jul 28, 2025 at 05:05:46PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> > Should it be "/d/a/git/git/..." instead of "D:/a/git/git/..."? Which we
> > could get by using $PWD, I think.
> >
> > The earlier one using $HOME uses D:/, but this one is different because
> > colons are meaningful separators in $PATH.
> 
> Here is what I have on top of the posted patches.  If today's
> integration goes well, I plan to merge it to 'next'; the rest of the
> series is already in 'next'.

Looks good. Not sure if you saw the patch I posted in this thread. It's roughly the same as yours, though I didn't drop the useless "env" (which I agree is useless).

I did reference 71dd50472d (t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variables, 2016-11-11) to try to give more explanation of the two different sources. But re-reading it, it actually doesn't really clarify much. ;) So maybe not worth worrying about.

-Peff