git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] SubmittingPatches: address design critiques

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 22, 2026, 12:57 UTC
Message-ID
<xmqqh5mu3f86.fsf@gitster.g>
In-Reply-To
<ajjwYGWZ6hQWr600@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 21 quoted lines
> On Sat, Jun 20, 2026 at 04:43:00PM -0700, Junio C Hamano wrote:
>> Contributors sometimes fail to answer fundamental design or
>> viability comments from reviewers and submit subsequent rounds
>> without addressing them.  When design decisions are resolved on the
>> mailing list, the final justification should be recorded in the
>> commit messages.
>> 
>> Instruct authors to be particularly mindful of critiques regarding
>> high-level design or viability, to defend their choices on the list,
>> and to accompany new iterations with clearer explanations in the cover
>> letter, responses, and revised commit messages. Also instruct them to
>> explicitly document the resolution of these concerns in the commit
>> message body to keep the historical record complete.
>> 
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  * Hopefully this will be the last iteration.
>
> This version looks good to me, thanks!
>
> Patrick
Thanks.
Previous: Patrick Steinhardt
Message 8 of 8 in “SubmittingPatches: address design critiques”
  1. SubmittingPatches: address design critiquesJunio C Hamano, Jun 17, 2026
  2. SubmittingPatches: address design critiquesJunio C Hamano, Jun 18, 2026
  3. Kristoffer HaugsbakkJun 18, 2026
  4. Junio C HamanoJun 18, 2026
  5. SubmittingPatches: address design critiquesJunio C Hamano, Jun 19, 2026
  6. SubmittingPatches: address design critiquesJunio C Hamano, Jun 20, 2026
  7. Patrick SteinhardtJun 22, 2026
  8. Junio C HamanoJun 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.