Re: [PATCH v2] SubmittingPatches: address design critiques
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 18, 2026, 16:26 UTC
- Message-ID
- <xmqq4iizstlm.fsf@gitster.g>
- In-Reply-To
- <95cd81dc-baea-4318-9f01-6a795f8eb5bb@app.fastmail.com>
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
Show 7 quoted lines
> You can imagine someone from group number 1 who is *not* in group number > 3 use a weekend to implement something. But then when it is submitted it > turns out that is a very “centralized CVS” idea which doesn’t fit into > git(1) at all. That’s easily spotted by group number 3 by just looking > at the proposed docs or design. Now that group number 1 individual might > just have a bunch of code that is dead weight for any proper Git > workflow.
That depends on how obviously wrong the idea is. If your proposal is to write another CVS into Git, that may be too obvious it may not fly, but the thing is, "proposals" that get the canned response you quoted are often vague enough that crucial details that divide "iffy" and "obviously wrong" are missing.
One way to make these proposals sufficiently clear to allow reviewers to tell the difference is with a code that builds. There may be other ways, but that is one obvious way to start a meaningful discussion.