git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] SubmittingPatches: address design critiques

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 18, 2026, 16:26 UTC
Message-ID
<xmqq4iizstlm.fsf@gitster.g>
In-Reply-To
<95cd81dc-baea-4318-9f01-6a795f8eb5bb@app.fastmail.com>
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
Show 7 quoted lines
> You can imagine someone from group number 1 who is *not* in group number
> 3 use a weekend to implement something. But then when it is submitted it
> turns out that is a very “centralized CVS” idea which doesn’t fit into
> git(1) at all. That’s easily spotted by group number 3 by just looking
> at the proposed docs or design. Now that group number 1 individual might
> just have a bunch of code that is dead weight for any proper Git
> workflow.

That depends on how obviously wrong the idea is. If your proposal is to write another CVS into Git, that may be too obvious it may not fly, but the thing is, "proposals" that get the canned response you quoted are often vague enough that crucial details that divide "iffy" and "obviously wrong" are missing.

One way to make these proposals sufficiently clear to allow reviewers to tell the difference is with a code that builds. There may be other ways, but that is one obvious way to start a meaningful discussion.

Previous: Kristoffer HaugsbakkNext: Junio C Hamano
Message 4 of 8 in “SubmittingPatches: address design critiques”
  1. SubmittingPatches: address design critiquesJunio C Hamano, Jun 17, 2026
  2. SubmittingPatches: address design critiquesJunio C Hamano, Jun 18, 2026
  3. Kristoffer HaugsbakkJun 18, 2026
  4. Junio C HamanoJun 18, 2026
  5. SubmittingPatches: address design critiquesJunio C Hamano, Jun 19, 2026
  6. SubmittingPatches: address design critiquesJunio C Hamano, Jun 20, 2026
  7. Patrick SteinhardtJun 22, 2026
  8. Junio C HamanoJun 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.