Re: [PATCH v2] negotiator/skipping.c: parse parents before queueing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 23, 2026, 14:30 UTC
- Message-ID
- <xmqqh5icbial.fsf@gitster.g>
- In-Reply-To
- <atqSs0yzXw0cf3cH@com-79390>
Taylor Blau <ttaylorr@openai.com> writes:
Show 9 quoted lines
> On Thu, Oct 22, 2026 at 03:34:25PM -0700, Junio C Hamano wrote: >> Perhaps rev_list_push() should mark the commit as 'SEEN' only after >> repo_parse_commit() succeeds? > > I considered this but ultimately decided against it, since the default > negotiator does: > ... > There are various callers of rev_list_push() in the default negotiator, > but all include SEEN in the provided 'mark'.
It is understandable that we do not want to widen the scope of the patch by adding a preparatory "fix the existing ones" step, but I do not think "the existing ones make the same mistake" is particularly a good excuse to add new one. Would a hybrid approach to (1) avoid copying a mistake to new code and (2) document near the new code and/or in the log message that the difference is deliberate and fixing existing ones are #leftoverbits and not addressed in this commit?