Re: [PATCH v2] negotiator/skipping.c: parse parents before queueing
- From
Taylor Blau <ttaylorr@openai.com>
- Date
- Oct 22, 2026, 22:48 UTC
- Message-ID
- <atqSs0yzXw0cf3cH@com-79390>
- In-Reply-To
- <xmqqld7pcqku.fsf@gitster.g>
On Thu, Oct 22, 2026 at 03:34:25PM -0700, Junio C Hamano wrote:
> Perhaps rev_list_push() should mark the commit as 'SEEN' only after > repo_parse_commit() succeeds?
I considered this but ultimately decided against it, since the default negotiator does:
static void rev_list_push(struct negotiation_state *ns,
struct commit *commit, int mark)
{
if (!(commit->object.flags & mark)) {
commit->object.flags |= mark; if (repo_parse_commit(the_repository, commit))
return;/* ... */
There are various callers of rev_list_push() in the default negotiator, but all include SEEN in the provided 'mark'.
Thanks, Taylor