Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 30, 2013, 21:05 UTC
Message-ID: <xmqqfvpaqcbu.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20131230205234.GU27213@leaf>

Josh Triplett <josh@joshtriplett.org> writes:

Show 5 quoted lines

>>  - The "everybody will have a single SP at the end" may or may not
>>    last forever;
>
> Trivially fixed if that ever changes, but given the nature of all of
> these, that seems unlikely.

Why? Because we encourage to write tests that are expected to find breakages, some of these test vector lines may have to show a broken line that lacks SP after label + colon.

>>  - With your scheme, if you already had _one_ trailing SPs in the
>>    input, it would be hard to spot in the source;
>
> Git makes them quite difficult to miss. :)

That is irrelevant, isn't it?

This is about protecting the source in the editor, before you run "git show --whitespace=trailing-space", "git diff --check", etc.