Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"

From: Josh Triplett <josh@joshtriplett.org>
Date: Dec 30, 2013, 20:52 UTC
Message-ID: <20131230205234.GU27213@leaf>
In-Reply-To: <xmqqk3emqd7a.fsf@gitster.dls.corp.google.com>

On Mon, Dec 30, 2013 at 12:46:33PM -0800, Junio C Hamano wrote:

Show 36 quoted lines

> Josh Triplett <josh@joshtriplett.org> writes:
> 
> > On Mon, Dec 30, 2013 at 09:19:55AM -0800, Junio C Hamano wrote:
> >> Christian Couder <chriscool@tuxfamily.org> writes:
> >> 
> >> > +# Do not remove trailing spaces below!
> >> > +cat >complex_message_trailers <<'EOF'
> >> > +Fixes: 
> >> > +Acked-by: 
> >> > +Reviewed-by: 
> >> > +Signed-off-by: 
> >> > +EOF
> >> 
> >> Just a hint.  I think it is far safer and robust over time to do
> >> something like this:
> >> 
> >> 	sed -e 's/ Z$/ /' <<-\EOF
> >>         Fixes: Z
> >>         Acked-by: Z
> >>         EOF
> >> 
> >> instead of a comment, which can warn human developers but does not
> >> do anything to prevent their editors' auto-fix features from kicking
> >> in.
> >
> > This, but for simplicity, since every line needs the trailing space, why
> > not just use 's/$/ /' and drop the ' Z' on every line?
> >
> > </bikeshed>
> >
> > - Josh Triplett
> 
> A few reasons:
> 
>  - The "everybody will have a single SP at the end" may or may not
>    last forever;

Trivially fixed if that ever changes, but given the nature of all of these, that seems unlikely.

>  - With your scheme, if you already had _one_ trailing SPs in the
>    input, it would be hard to spot in the source;

Git makes them quite difficult to miss. :)

- Josh Triplett