git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] write_pack_file: use correct variable in diagnostic

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 3, 2014, 18:43 UTC
Message-ID
<xmqqfvmzqg1u.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1393745411-30980-1-git-send-email-sunheehnus@gmail.com>
Sun He <sunheehnus@gmail.com> writes:
Show 26 quoted lines
> 'pack_tmp_name' is the subject of the utime() check, so report it in the
> warning, not the uninitialized 'tmpname'
>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
>  Changing the subject and adding valid information as tutored by 
>  Eric Sunshine.
>  Thanks to him.
>
>  builtin/pack-objects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>  				utb.modtime = --last_mtime;
>  				if (utime(pack_tmp_name, &utb) < 0)
>  					warning("failed utime() on %s: %s",
> -						tmpname, strerror(errno));
> +						pack_tmp_name, strerror(errno));
>  			}
>  
>  			/* Enough space for "-<sha-1>.pack"? */
Very nicely done.  Thanks.
And big Thanks to Eric guiding this patch through.
Previous: He Sun
Message 4 of 4 in “write_pack_file: use correct variable in diagnostic”
  1. write_pack_file: use correct variable in diagnosticSun He, Mar 2, 2014
  2. Eric SunshineMar 2, 2014
  3. He SunMar 3, 2014
  4. Junio C HamanoMar 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.