From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 03 Mar 2014 18:43:09 GMT
Subject: Re: [PATCH v3] write_pack_file: use correct variable in diagnostic
Message-ID: <xmqqfvmzqg1u.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1393745411-30980-1-git-send-email-sunheehnus@gmail.com>

Sun He <sunheehnus@gmail.com> writes:

> 'pack_tmp_name' is the subject of the utime() check, so report it in the
> warning, not the uninitialized 'tmpname'
>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
>  Changing the subject and adding valid information as tutored by 
>  Eric Sunshine.
>  Thanks to him.
>
>  builtin/pack-objects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>  				utb.modtime = --last_mtime;
>  				if (utime(pack_tmp_name, &utb) < 0)
>  					warning("failed utime() on %s: %s",
> -						tmpname, strerror(errno));
> +						pack_tmp_name, strerror(errno));
>  			}
>  
>  			/* Enough space for "-<sha-1>.pack"? */

Very nicely done.  Thanks.

And big Thanks to Eric guiding this patch through.