git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] ls-tree: disable negative pathspec because it's not supported

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 1, 2014, 19:40 UTC
Message-ID
<xmqqfvczp39n.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1417338302-8208-4-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

Hmph, that's sad. Should the below say "test_expect_failure" without "test_must_fail", anticipating a fix later?

 t/t3102-ls-tree-wildcards.sh | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/t/t3102-ls-tree-wildcards.sh b/t/t3102-ls-tree-wildcards.sh
index 83fca8d..93127a0 100755
--- a/t/t3102-ls-tree-wildcards.sh
+++ b/t/t3102-ls-tree-wildcards.sh
@@ -27,4 +27,8 @@ EOF
 	test_cmp expected actual
 '
 
+test_expect_success 'ls-tree rejects negated pathspec' '
+	test_must_fail git ls-tree -r HEAD ":(exclude)a" "a*"
+'
+
 test_done
Previous: Nguyễn Thái Ngọc DuyNext: Duy Nguyen
Message 10 of 11 in “ls-tree fixes”
  1. 0/3 ls-tree fixesNguyễn Thái Ngọc Duy, Nov 30, 2014
  2. 1/3 tree.c: update read_tree_recursive callback to pass strbuf as baseNguyễn Thái Ngọc Duy, Nov 30, 2014
  3. Junio C HamanoDec 1, 2014
  4. Duy NguyenDec 2, 2014
  5. Eric SunshineDec 3, 2014
  6. Junio C HamanoDec 3, 2014
  7. Duy NguyenDec 8, 2014
  8. 2/3 ls-tree: remove path filtering logic in show_treeNguyễn Thái Ngọc Duy, Nov 30, 2014
  9. 3/3 ls-tree: disable negative pathspec because it's not supportedNguyễn Thái Ngọc Duy, Nov 30, 2014
  10. Junio C HamanoDec 1, 2014
  11. Duy NguyenDec 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.