git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

From
Duy Nguyen <pclouds@gmail.com>
Date
Dec 2, 2014, 12:11 UTC
Message-ID
<CACsJy8B7G9xQerZ+6GTPQuG2v1DuJLXfsKFobuz_vyFahnXuYQ@mail.gmail.com>
In-Reply-To
<xmqqk32bp3nk.fsf@gitster.dls.corp.google.com>
On Tue, Dec 2, 2014 at 2:32 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> This allows the callback to use 'base' as a temporary buffer to
>> quickly assemble full path "without" extra allocation. The callback
>> has to restore it afterwards of course.
>
> Hmph, what's the quote around 'without' doing there?

because it's only true if you haven't used up all preallocated space in strbuf. If someone passes an empty strbuf, then underneath strbuf may do a few realloc until the buffer is large enough.

-- 
Duy
Previous: Junio C HamanoNext: Eric Sunshine
Message 4 of 11 in “ls-tree fixes”
  1. 0/3 ls-tree fixesNguyễn Thái Ngọc Duy, Nov 30, 2014
  2. 1/3 tree.c: update read_tree_recursive callback to pass strbuf as baseNguyễn Thái Ngọc Duy, Nov 30, 2014
  3. Junio C HamanoDec 1, 2014
  4. Duy NguyenDec 2, 2014
  5. Eric SunshineDec 3, 2014
  6. Junio C HamanoDec 3, 2014
  7. Duy NguyenDec 8, 2014
  8. 2/3 ls-tree: remove path filtering logic in show_treeNguyễn Thái Ngọc Duy, Nov 30, 2014
  9. 3/3 ls-tree: disable negative pathspec because it's not supportedNguyễn Thái Ngọc Duy, Nov 30, 2014
  10. Junio C HamanoDec 1, 2014
  11. Duy NguyenDec 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.