Re: [PATCH] bisect: print abbrev sha1 for first bad commit

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2015, 16:54 UTC
Message-ID: <xmqqfv73f420.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAP8UFD1Aq54dWvxo5JTP4Fqy5u-qhA0LAm3vRrw9=jYg3o_F+g@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 12 quoted lines

> On Mon, May 11, 2015 at 6:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Jeff King <peff@peff.net> writes:
>>
>>> I'd argue for simply never showing the diff (dropping the "opt.diff = 1"
>>> line from bisect.c:show_diff_tree), but that is mostly my personal
>>> opinion.
>>
>> Yeah, I think that is sensible. It may even be OK to just give a
>> "log --oneline".
>
> Or maybe we could let the user configure the diff options or even the
> command used when the first bad commit is found?

That is a separate discussion. I do not mind but I doubt many people would use it (I was tempted to say "doubt anybody would", but then was reminded how many people use Git, and toned it down), as long as we have a good default. And I thought that this discussion was about coming up with a good-enough default.

To be bluntly honest, I think the current one is sufficient as a good-enough default. The first thing I would do after seeing that message is to either "git checkout <commit-object-name>" or "git show <commit-object-name>", and the current full 40-hex output gives me an easier mouse-double-click target than the proposed abbreviated one, so in that sense the original proposal may even be a usability regression.

It is tempting to say that the output can be eliminated by always checking out the first-bad-commit (i.e. only when the last answer that led to the first-bad decision was "good", do a "git checkout" of that bad commit), but in a project where a branch switching is not instantaneous, that might be problematic (unless the first step the user would have done is to check it out anyway, of course).