git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect: print abbrev sha1 for first bad commit

From
Junio C Hamano <gitster@pobox.com>
Date
May 12, 2015, 17:11 UTC
Message-ID
<xmqq7fsd201d.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAP8UFD3LzM3uuUzWYS-o6mhtH-x5+-kyGhDvYnv6ZPRTC18C6w@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 22 quoted lines
> On Mon, May 11, 2015 at 6:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> To be bluntly honest, I think the current one is sufficient as a
>> good-enough default.  The first thing I would do after seeing that
>> message is to either "git checkout <commit-object-name>" or "git
>> show <commit-object-name>", and the current full 40-hex output gives
>> me an easier mouse-double-click target than the proposed abbreviated
>> one, so in that sense the original proposal may even be a usability
>> regression.
>
> Yeah, it might also be a regression if some users have scripts that
> depend on the current behavior.
> ...
>> It is tempting to say that the output can be eliminated by always
>> checking out the first-bad-commit (i.e. only when the last answer
>> that led to the first-bad decision was "good", do a "git checkout"
>> of that bad commit), but in a project where a branch switching is
>> not instantaneous, that might be problematic (unless the first step
>> the user would have done is to check it out anyway, of course).
>
> Yeah, and speaking of regressions, elimiting the output might be a
> more serious regression.
I am getting somewhat annoyed by this line of thought.

Who said bisect output is meant to be parseable and be read by scripts in the first place? If that were the case, we wouldn't be having this discussion thread in the first place.

Previous: Christian CouderNext: Christian Couder
Message 13 of 17 in “bisect: print abbrev sha1 for first bad commit”
  1. bisect: print abbrev sha1 for first bad commitTrevor Saunders, May 8, 2015
  2. Stefan BellerMay 9, 2015
  3. Trevor SaundersMay 9, 2015
  4. Jeff KingMay 9, 2015
  5. Trevor SaundersMay 10, 2015
  6. Jeff KingMay 11, 2015
  7. Junio C HamanoMay 11, 2015
  8. Christian CouderMay 11, 2015
  9. Junio C HamanoMay 11, 2015
  10. Trevor SaundersMay 11, 2015
  11. Stefan BellerMay 11, 2015
  12. Christian CouderMay 12, 2015
  13. Junio C HamanoMay 12, 2015
  14. Christian CouderMay 12, 2015
  15. Stefan BellerMay 12, 2015
  16. Trevor SaundersMay 12, 2015
  17. Christian CouderMay 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.