Re: [PATCHv1 2/2] git-p4: work with a detached head

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 28, 2015, 17:44 UTC
Message-ID: <xmqqfv0ulwgj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAE5ih7-_zhxf_daVxNB-hxFfbakMbJp9rk0vP+k46ErrJ6Qxiw@mail.gmail.com>

Luke Diamand <luke@diamand.org> writes:

Show 15 quoted lines

> On 9 September 2015 at 22:52, Junio C Hamano <gitster@pobox.com> wrote:
>> Luke Diamand <luke@diamand.org> writes:
>> ...
>>     def currentGitBranch():
>>         return read_pipe("git name-rev HEAD").split(" ")[1].strip()
>>
>> Yuck.  I know it is not entirely the fault of this patch, but
>> shouldn't it be reading from
>>
>>     $ git symbolic-ref HEAD
>>
>> and catch the error "fatal: ref HEAD is not a symbolic ref" and use
>> it as a signal to tell that the HEAD is detached?
>
> That sounds much nicer. I'll redo the patch accordingly.

No need to rush, but should I expect a reroll of this sometime, or have things around this topic changed to make this topic no longer necessary? I am only asking so that I can decide to either keep or drop ld/p4-detached-head topic that is listed in the [Stalled] section for quite some time [*1*].

Thanks.

[Footnote]

*1* Not that my dropping a topic from 'pu' means very much; a
    dropped topic can still be submitted and requeued after all.