git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv1 1/2] git-p4: add failing test for submit from detached head

From
Luke Diamand <luke@diamand.org>
Date
Sep 5, 2015, 14:02 UTC
Message-ID
<1441461738-25066-2-git-send-email-luke@diamand.org>
In-Reply-To
<1441461738-25066-1-git-send-email-luke@diamand.org>

git-p4 can't submit from a detached head. This test case demonstrates the problem.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9800-git-p4-basic.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 90d41ed..114b19f 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -241,6 +241,22 @@ test_expect_success 'unresolvable host in P4PORT should display error' '
 	)
 '
 
+test_expect_failure 'submit from detached head' '
+	test_when_finished cleanup_git &&
+	git p4 clone --dest="$git" //depot &&
+	(
+		cd "$git" &&
+		git checkout p4/master &&
+		>detached_head_test &&
+		git add detached_head_test &&
+		git commit -m "add detached_head" &&
+		git config git-p4.skipSubmitEdit true &&
+		git p4 submit &&
+		git p4 rebase &&
+		git log p4/master | grep detached_head
+	)
+'
+
 test_expect_success 'kill p4d' '
 	kill_p4d
 '
-- 
2.6.0.rc0.133.ga438a11.dirty
Previous: Luke DiamandNext: Luke Diamand
Message 2 of 12 in “[PATCHv1 0/2] git-p4: work on a detached head”
  1. Luke DiamandSep 5, 2015
  2. 1/2 git-p4: add failing test for submit from detached headLuke Diamand, Sep 5, 2015
  3. 2/2 git-p4: work with a detached headLuke Diamand, Sep 5, 2015
  4. Junio C HamanoSep 9, 2015
  5. Luke DiamandSep 10, 2015
  6. Junio C HamanoSep 10, 2015
  7. Junio C HamanoOct 28, 2015
  8. Luke DiamandOct 28, 2015
  9. Lars SchneiderSep 9, 2015
  10. Jacob KellerSep 10, 2015
  11. Jacob KellerSep 10, 2015
  12. Luke DiamandSep 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.