Re: What's cooking in git.git (Feb 2016, #07; Thu, 25)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2016, 18:21 UTC
Message-ID: <xmqqfuwcg0g8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <56D1DF53.1010006@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

> How about something like this as a workaround ?
> (I can send a proper patch, if this is the way forward)
> ...
>     Make Git compile under Mac OS X 10.6 by using clang instead of gcc

Given that it is understandable that Apple is no longer interesting in fixing compiler bugs for 10.6, I think that is the best we could do to help its users.

> ...
> +       ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 10 &&
> echo 1),1)

This singles out 10.6-and-nothing-else, 10.6-or-older or 10.6-or-newer?

That "-ge", which smells like a copy-and-pasta from the next one that says "we have getdelim on 10.7-and-newer" bothers me.

Show 6 quoted lines

> +    CC = clang
> +       endif
>         ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 11 &&
> echo 1),1)
>                 HAVE_GETDELIM = YesPlease
>         endif