Re: What's cooking in git.git (Feb 2016, #07; Thu, 25)
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Feb 26, 2016, 16:10 UTC
- Message-ID
- <56D078F3.9070905@web.de>
- In-Reply-To
- <xmqqfuwgmlgy.fsf@gitster.mtv.corp.google.com>
Show 29 quoted lines
> * jk/tighten-alloc (2016-02-22) 22 commits
> (merged to 'next' on 2016-02-24 at 78b3251)
> + ewah: convert to REALLOC_ARRAY, etc
> + convert ewah/bitmap code to use xmalloc
> + diff_populate_gitlink: use a strbuf
> + transport_anonymize_url: use xstrfmt
> + git-compat-util: drop mempcpy compat code
> + sequencer: simplify memory allocation of get_message
> + test-path-utils: fix normalize_path_copy output buffer size
> + fetch-pack: simplify add_sought_entry
> + fast-import: simplify allocation in start_packfile
> + write_untracked_extension: use FLEX_ALLOC helper
> + prepare_{git,shell}_cmd: use argv_array
> + use st_add and st_mult for allocation size computation
> + convert trivial cases to FLEX_ARRAY macros
> + use xmallocz to avoid size arithmetic
> + convert trivial cases to ALLOC_ARRAY
> + convert manual allocations to argv_array
> + argv-array: add detach function
> + add helpers for allocating flex-array structs
> + harden REALLOC_ARRAY and xcalloc against size_t overflow
> + tree-diff: catch integer overflow in combine_diff_path allocation
> + add helpers for detecting size_t overflow
> + reflog_expire_cfg: NUL-terminate pattern field
>
> Update various codepaths to avoid manually-counted malloc().
>
> Will merge to 'master'.
> Sorry being late, but this is what my older test system says:
CC combine-diff.o combine-diff.c: In function ‘diff_tree_combined’: combine-diff.c:1391: internal compiler error: Segmentation fault Please submit a full bug report, with preprocessed source if appropriate. See <URL:http://developer.apple.com/bugreporter> for instructions. make: *** [combine-diff.o] Error 1
Revert "use st_add and st_mult for allocation size computation" didn't fix it. I haven't digged deeper yet.