Re: Tabs in commit messages - de-tabify option in strbuf_stripspace()?

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2016, 16:47 UTC
Message-ID: <xmqqfuvq5pz7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+55aFwFsBKZZeqhBDf_YXG6vrSrvfFVCsRc0mkFUiDS9Rd+QA@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 14 quoted lines

> On Wed, Mar 16, 2016 at 7:27 AM, Marc Branchaud <marcnarc@xiplink.com> wrote:
>>
>> Could this also help with diff output, where the leading + or - mars the
>> indentation in a similar way?
>
> I don't think that's a good idea at least by default, since then it
> will break things like running diff in emacs capture mode.
>
> So even if you're in a terminal, you can't assume that you can munge
> the output too much.
>
> Of course, if colorization is on, you might as well pretty-print the
> diff by indenting things properly too, since the end result isn't
> going to be used as a _diff_.

I agree that I will never use such an end result as a diff, but I may still be tempted to cut-and-paste individual lines after '^+' when resurrecting a WIP topic that does not rebase very well, so I agree with you that the output shouldn't be munged by default even though I think it is OK to have an option..