Re: Tabs in commit messages - de-tabify option in strbuf_stripspace()?

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 16, 2016, 04:57 UTC
Message-ID: <CA+55aFyFHmmoHMgRkuBqNUho=tiJ=VwxHWzcGw3pRjr+aGS7ZQ@mail.gmail.com>
In-Reply-To: <xmqqzitz58si.fsf@gitster.mtv.corp.google.com>

On Tue, Mar 15, 2016 at 9:46 PM, Junio C Hamano <gitster@pobox.com> wrote:

>
> It also ignores that byte counts of non-HT bytes may not necessarily
> match display columns.  There is utf8_width() function exported from
> utf8.c for that purpose.

Hmm. I did that to now make it horribly slower. Doing the per-character widths really does horrible things for performance.

That said, I think I can make it do the fast thing for lines that have no tabs at all, which is the big bulk of it. So it would do the width calculations only in the rare "yes, I found a tab" case.

I already wrote it in a way that non-tab lines end up just looping over the line looking for a tab and then fall back to the old code.

I might just have to make that behavior a bit more explicit. Let me stare at it a bit, but it won't happen until tomorrow, I think.

                 Linus