Re: [PATCH v3] log --graph: customize the graph lines with config log.graphColors

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2017, 14:23 UTC
Message-ID: <xmqqfukswbvw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8AjW1TrLO28mSUSTc6V+_0kuShf7V-=Pkw3Cw9t7ZRfyw@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 8 quoted lines

> On Mon, Jan 9, 2017 at 12:30 PM, Jeff King <peff@peff.net> wrote:
>> I also wonder if it is worth just using argv_array. We do not care about
>> ...
>> It is not much shorter than ALLOC_GROW(), but IMHO it is easier to read.
>
> Indeed. My only complaint is it's "argv_array_" and not
> "string_array_" but we could think about renaming it later when we see
> another use like this.

Yup, when Peff said "argv-array", it took me a few breaths, until I realized that argv-array was merely an array of strings, to convince myself that the data structure can be used here. If we are going to use it in more places, we may want to rename it somehow.